Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change recover_polynomial to recover_all_cells #3702

Merged
merged 4 commits into from
Apr 19, 2024
Merged

Change recover_polynomial to recover_all_cells #3702

merged 4 commits into from
Apr 19, 2024

Conversation

kevaundray
Copy link
Contributor

This fixes two abstraction leaks:

  • The Polynomial type was being exposed to the user
  • The caller was also grouping the returned polynomial into cell types, meaning that das_core.md needed to know about FIELD_ELEMENTS_PER_CELL and CELLS_PER_EXT_BLOB in recover_matrix.

asn-d6
asn-d6 reviewed Apr 19, 2024
View reviewed changes
Copy link
Contributor

@asn-d6 asn-d6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Seems like CI is not truly happy though.

jtraglia
jtraglia approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jtraglia jtraglia merged commit bc69c35 into ethereum:dev Apr 19, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asn-d6 asn-d6 asn-d6 left review comments

@jtraglia jtraglia jtraglia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevaundray @asn-d6 @jtraglia